fmorg-git commented on code in PR #10009:
URL: https://github.com/apache/ozone/pull/10009#discussion_r3278319117
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketSetAclRequest.java:
##########
@@ -54,14 +54,15 @@ public class OMBucketSetAclRequest extends
OMBucketAclRequest {
@Override
public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
- long modificationTime = Time.now();
- OzoneManagerProtocolProtos.SetAclRequest.Builder setAclRequestBuilder =
+ final long modificationTime = Time.now();
+ final OzoneManagerProtocolProtos.SetAclRequest.Builder
setAclRequestBuilder =
getOmRequest().getSetAclRequest().toBuilder()
.setModificationTime(modificationTime);
- return getOmRequest().toBuilder()
+ // super.preExecute resolves S3Authentication (STS) for Ratis apply.
Merge SetAclRequest changes on top.
+ final OMRequest request = super.preExecute(ozoneManager);
Review Comment:
> There are two other requests, OMBucketAddAclRequest,
OMBucketRemoveAclRequest. So we should consider move this to OMBucketAclRequest.
updated as part of 6d43f3971493255c82538f7f413466a81380bfe0. I changed the
subclasses directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
