navinko commented on code in PR #10313:
URL: https://github.com/apache/ozone/pull/10313#discussion_r3284205493
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SequenceIdGenerator.java:
##########
@@ -259,18 +254,18 @@ public Boolean allocateBatch(String sequenceIdName,
try {
transactionBuffer
- .addToBuffer(sequenceIdTable, sequenceIdName, newLastId);
+ .addToBuffer(sequenceIdTable, idType.name(), newLastId);
} catch (IOException ioe) {
throw new RuntimeException("Failed to put lastId to Batch", ioe);
}
- sequenceIdToLastIdMap.put(sequenceIdName, newLastId);
+ sequenceIdToLastIdMap.put(idType, newLastId);
return true;
}
@Override
public Long getLastId(String sequenceIdName) {
Review Comment:
Thanks @szetszwo updated the changes
- updated interface method signature and impl
- updated the existing test cases
- ran test locally and build success
- CI build progressing :
https://github.com/navinko/ozone/actions/runs/26251573876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
