fmorg-git commented on PR #10266: URL: https://github.com/apache/ozone/pull/10266#issuecomment-4531829945
Hi all, Thanks for tagging me on this. There are a number of red flags raised for me by this PR: 1) I talked internally with some committers and long-time PMC members and no one has ever heard of this contributor 2) The contributor mentioned "My preference is to keep this PR together for now (I am lazy haha), since the pieces are connected already and the current PR already shows the full MVP flow end-to-end." This tells me that the contributor is not experienced as a programmer and/or does not have sufficient programming discipline and/or does not appreciate the sensitivity and security aspects of this PR and/or something much worse. For such a security impactful PR, even suggesting to review 6000+ lines in one swoop in a **major** red flag. 3) Per the Ozone guidelines I was given, the proper process is to have the design reviewed and accepted and then create a separate feature branch and have a separate epic with Jira tickets, and then break this PR into comprehensible and digestible chunks. This PR should probably be at least 10 PRs. Therefore, I am respectfully asking any committer that reviews - **PLEASE DO NOT MERGE ANY LINE OF THIS CODE INTO THE HDDS-13323-sts feature branch**. I am not comfortable with the high level of risk to pollute the `HDDS-13323-sts feature branch` with this code. If the design is accepted, please create a **separate** feature branch and separate epic in Jira with multiple tickets, and break this PR into reasonable chunks. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
