adoroszlai opened a new pull request, #10360:
URL: https://github.com/apache/ozone/pull/10360

   ## What changes were proposed in this pull request?
   
   Shell completion, implemented in HDDS-12811, knows about only very few 
commands:
   
   ```bash
   $ ozone completion bash | grep 'local cmds'
     local cmds0=(genconf)
     local cmds1=(getconf)
     local cmds2=(completion)
     local cmds3=(ratis)
     local cmds4=(getconf confKey)
     local cmds5=(getconf -confKey)
     local cmds6=(getconf storagecontainermanagers)
     local cmds7=(getconf -storagecontainermanagers)
     local cmds8=(getconf ozonemanagers)
     local cmds9=(getconf -ozonemanagers)
     local cmds10=(completion bash)
     local cmds11=(completion zsh)
   ```
   
   It was broken by HDDS-14595, which removed `ozone-cli-shell` etc. from 
classpath of `ozone-tools`.
   
   This PR changes `ozone completion` to run in `ozone-dist`, the module which 
depends on all other Ozone modules.  This makes all `ozone` subcommands 
available on the classpath.
   
   https://issues.apache.org/jira/browse/HDDS-15367
   
   ## How was this patch tested?
   
   ```
   $ ozone completion bash | grep 'local cmds' | wc -l
   344
   ```
   
   Also tested completion after:
   
   ```bash
   $ source <(ozone completion bash)
   $ ozone <TAB><TAB>
   admin       completion  debug       freon       genconf     getconf     
ratis       repair      s3          sh          tenant      vapor       
   $ ozone debug <TAB><TAB>
   auditparser  checknative  datanode     kerberos     ldb          log         
 om           ratis        replicas     version      
   ```
   
   CI:
   https://github.com/adoroszlai/ozone/actions/runs/26406422556


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to