ChenSammi commented on code in PR #10312:
URL: https://github.com/apache/ozone/pull/10312#discussion_r3301536328
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -586,11 +586,12 @@ enum DiskBalancerRunningStatus {
message VolumeReportProto {
optional string storageId = 1;
optional string storagePath = 2;
- optional uint64 totalCapacity = 3;
- optional uint64 usedSpace = 4;
+ optional uint64 ozoneCapacity = 3;
Review Comment:
It's not a good practice to rename an existing proto field.
We can add a comment for these fields, that they are data for ozone data
volume only, not the whole disk volume.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
