slfan1989 commented on PR #10364: URL: https://github.com/apache/ozone/pull/10364#issuecomment-4550276804
> Thanks @slfan1989 for the patch. > > Can we use `Clock` instead of hard-coded time source? (`MonotonicClock` in prod, `TestClock` in test to avoid the need for sleep (`waitFor`).) @adoroszlai Thanks for the suggestion. I have updated the implementation to inject a `Clock`: `SlidingWindow.MonotonicClock` is used in production, and `TestClock` is used in the test. This removes the real-time wait from `testOldReplicaDelayedDeletion`, as the test can now advance the clock directly. Please take another look when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
