greenwich commented on code in PR #10362:
URL: https://github.com/apache/ozone/pull/10362#discussion_r3308246262
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainer.java:
##########
@@ -186,10 +175,10 @@ public void create(VolumeSet volumeSet,
VolumeChoosingPolicy
containerData.setCommittedSpace(true);
} catch (DiskOutOfSpaceException ex) {
throw new StorageContainerException("Container creation failed, " +
- "due to disk out of space", ex, DISK_OUT_OF_SPACE);
+ "due to disk out of space on StorageType: " + storageType, ex,
DISK_OUT_OF_SPACE);
Review Comment:
nit: as `storageType` is nullable, we can end up with messages with null
like:
- "Container creation failed, due to disk out of space on StorageType:
null"
- "Container creation failed on StorageType:null. <inner msg>"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
