ChenSammi commented on PR #10353: URL: https://github.com/apache/ozone/pull/10353#issuecomment-4552589390
@smengcl , thanks for working on this. The idea overall looks good to me. Stream read uses KeyValueHandler#readBlockImpl, it's not covered in the patch. Further more, we should consider add a limit to the direct buffer pool in case it causes OOM failure. There is an existing example, BoundedElasticByteBufferPool. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
