devmadhuu commented on PR #10304: URL: https://github.com/apache/ozone/pull/10304#issuecomment-4554603832
Thanks @priyeshkaratha for the patch. Some observations: 1. `dn-overview.html` and `dn.js` still reference `TotalCapacity`: - Remove the Total Capacity column (or replace with Min Free Space). - Add columns for MinFreeSpace and NonOzoneUsed with transform() in dn.js. 2. And as mentioned in PR description: "`Total Capacity and Filesystem Capacity represent the same value`" - But I think they are not same value, they are mathematically equal, but they meant different things (OzoneCapacity + Reserved vs raw FS capacity). Can you recheck this or they represent and referring same underlying value. 3. If we are removing the `TotalCapacity` , then did you verify if any grafana dashboards/alerts scrapes that jmx metric name anywhere ? Just make sure that it doesn't cause regression. 4. JMX exposes soft `MinFreeSpace` (`getReportedFreeSpaceToSpare`). Write path rejection uses hard `getFreeSpaceToSpare()`. Admin or developers debugging `numWriteRequestsRejectedHardMinFreeSpace` may want both. You want want to do in this or next PR, your call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
