will-sh opened a new pull request, #10374:
URL: https://github.com/apache/ozone/pull/10374

   ## What changes were proposed in this pull request?
   HDDS-15368. Remove static horizontal divider from ozone interactive shell
   
   The ozone interactive REPL (introduced under 
[HDDS-11825](https://issues.apache.org/jira/browse/HDDS-11826)) used JLine 
TailTipWidgets with TipType.COMPLETER to show command synopsis below Tab 
completion. That integration also enabled the JLine Status pane with a static 
horizontal border (────), which sometimes could caused poor UX when the 
terminal was resized, copied, or when completion overlapped.
   
   This change removes TailTipWidgets from the interactive REPL and relies on 
LineReader-only tab completion (AUTO_LIST, LIST_AMBIGUOUS, LIST_MAX=50). That 
eliminates the Status border and the duplicate or “ghost” completion lines seen 
after window resize (WINCH). A blank line is printed after each command (and 
after the startup banner) so the prompt is visually separated without a 
hardcoded rule line—aligned with common shells such as mysql and spark-shell.
   
   Additionally, a small startup banner (OzoneInteractiveWelcome) is shown when 
entering ozone interactive: Ozone release version, configured OM/SCM endpoints, 
and short hints for help, Tab completion, and ozone version. Shell exposes an 
interactiveWelcomeLines() hook (default empty); OzoneInteractiveShell overrides 
it to supply the banner.
   
   ## What is the link to the Apache JIRA
   https://issues.apache.org/jira/browse/HDDS-15368
   
   ## How was this patch tested?
   
   - CI is passed in fork repo
   - Tested ozone interactive command manually for tab completion and resizing 
the window
   
   Currently it is like below:
   ```
   bash-5.1$ ozone interactive
   Apache Ozone Interactive Shell 2.2.0-SNAPSHOT(Katmai)
   Using OM: om:9862
   Using SCM: scm:9860
   
   Type 'help' for command synopsis; 'exit' or Ctrl-D to quit.
   Press Tab to complete subcommands; type '-' then Tab to complete options.
   Run 'ozone version' for full build details.
   
   ozone> 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to