sarvekshayr commented on code in PR #10329:
URL: https://github.com/apache/ozone/pull/10329#discussion_r3322252623
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/bucket/acl/OMBucketSetAclRequest.java:
##########
@@ -54,6 +54,7 @@ public class OMBucketSetAclRequest extends OMBucketAclRequest
{
@Override
public OMRequest preExecute(OzoneManager ozoneManager) throws IOException {
+ super.preExecute(ozoneManager);
Review Comment:
Please address this comment from Copilot -
https://github.com/apache/ozone/pull/9653/changes#r3076604122
> Now that this method calls super.preExecute(ozoneManager),
OMClientRequest.preExecute will already populate UserInfo via
getUserIfNotExists(). The method later rebuilds the request and sets UserInfo
again via getUserInfo(), which can drop that fallback in non-RPC/internal call
paths (Server.getRemoteUser() may be null). Consider capturing the OMRequest
returned by super.preExecute and building from it without overriding UserInfo,
or switch the later setUserInfo call to getUserIfNotExists(ozoneManager).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
