sarvekshayr commented on code in PR #10330:
URL: https://github.com/apache/ozone/pull/10330#discussion_r3322348556
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeysDeleteRequest.java:
##########
@@ -166,25 +231,11 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager, Execut
continue;
}
- try {
- // check Acl
- long startNanosDeleteKeysAclCheckLatency = Time.monotonicNowNanos();
- checkKeyAcls(ozoneManager, volumeName, bucketName, keyName,
- IAccessAuthorizer.ACLType.DELETE, OzoneObj.ResourceType.KEY,
- volumeOwner);
- perfMetrics.setDeleteKeysAclCheckLatencyNs(Time.monotonicNowNanos()
- startNanosDeleteKeysAclCheckLatency);
Review Comment:
`deleteKeysAclCheckLatencyNs` metric is no longer updated after moving out
the ACL check from `validateAndUpdateCache()`. Let's restore the metric in
`OMKeysDeleteRequest.preExecute()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
