guihecheng commented on a change in pull request #2344:
URL: https://github.com/apache/ozone/pull/2344#discussion_r655152182
##########
File path: hadoop-hdds/common/src/main/resources/ozone-default.xml
##########
@@ -2901,4 +2901,15 @@
directory deleting service per time interval.
</description>
</property>
+
+ <property>
+ <name>ozone.scm.datanode.ratis.volume.free-space.min</name>
+ <value>0MB</value>
Review comment:
Oh, yes, will fix the default value and manually test smaller defaults
for related tests, thanks~
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelinePlacementPolicy.java
##########
@@ -158,15 +161,21 @@ int currentPipelineCount(DatanodeDetails datanodeDetails,
int nodesRequired) {
ScmConfigKeys.OZONE_SCM_CONTAINER_SIZE_DEFAULT,
StorageUnit.BYTES);
+ long metaSizeRequired = (long) conf.getStorageSize(
+ OZONE_DATANODE_RATIS_VOLUME_FREE_SPACE_MIN,
+ OZONE_DATANODE_RATIS_VOLUME_FREE_SPACE_MIN_DEFAULT,
+ StorageUnit.BYTES);
+
// filter nodes that don't even have space for one container
List<DatanodeDetails> canHoldList = healthyNodes.stream().filter(d ->
hasEnoughSpace(d, sizeRequired)).collect(Collectors.toList());
if (canHoldList.size() < nodesRequired) {
msg = String.format("Pipeline creation failed due to no sufficient" +
- " healthy datanodes with enough space for even a single container." +
- " Required %d. Found %d. Container size %d.",
- nodesRequired, canHoldList.size(), sizeRequired);
+ " healthy datanodes with enough space for container data or " +
Review comment:
OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
