adoroszlai commented on code in PR #10378:
URL: https://github.com/apache/ozone/pull/10378#discussion_r3328174730
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/BackgroundService.java:
##########
@@ -191,17 +191,21 @@ public void run() {
}
// shutdown and make sure all threads are properly released.
- public synchronized void shutdown() {
+ public void shutdown() {
LOG.info("Shutting down service {}", this.serviceName);
- exec.shutdown();
+ final ScheduledThreadPoolExecutor current;
+ synchronized (this) {
Review Comment:
Spotbugs may complain about inconsistent synchronization. That's why
`shutdown` was changed to `synchronized` in HDDS-13320
(https://github.com/apache/ozone/pull/8677#issuecomment-3101103389,
https://github.com/apache/ozone/pull/8677/commits/57f39f940e44df291d762251d1f5cb6443e78688).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
