adoroszlai opened a new pull request, #10421:
URL: https://github.com/apache/ozone/pull/10421

   ## What changes were proposed in this pull request?
   
   `langchain4j-bom` and `guice-bom` leak transitive dependencies defined in 
their parent POMs.
   
   - 
https://github.com/langchain4j/langchain4j/blob/0.35.0/langchain4j-bom/pom.xml#L8
   - 
https://github.com/langchain4j/langchain4j/blob/0.35.0/langchain4j-parent/pom.xml#L92-L126
   - 
https://github.com/langchain4j/langchain4j/blob/0.35.0/langchain4j-parent/pom.xml#L158-L433
   - https://github.com/google/guice/blob/6.0.0/bom/pom.xml#L8
   - https://github.com/google/guice/blob/6.0.0/pom.xml#L127-L199
   
   This overrides some of Ozone's own dependencies.  Example for production 
dependency:
   
   ```
   $ cd hadoop-ozone/dist/target/ozone-2.2.0-SNAPSHOT/share/ozone/lib
   $ ls slf4j*
   slf4j-api-2.0.7.jar
   slf4j-reload4j-2.0.17.jar
   ```
   
   Some test artifacts are also overridden, which was previously worked around 
by adding these dependencies again, despite having been imported from their own 
BOMs:
   
   
https://github.com/apache/ozone/blob/891cf0e86fe9b0bec15f86be60db28d1b553c1d3/pom.xml#L1613
   
https://github.com/apache/ozone/blob/891cf0e86fe9b0bec15f86be60db28d1b553c1d3/pom.xml#L1679
   
   This change replaces usage of these two BOMs with individual artifacts.
   
   https://issues.apache.org/jira/browse/HDDS-15468
   
   ## How was this patch tested?
   
   Verified `slf4j-api` version after build.
   
   ```
   $ cd hadoop-ozone/dist/target/ozone-2.2.0-SNAPSHOT/share/ozone/lib
   $ ls slf4j*
   slf4j-api-2.0.17.jar
   slf4j-reload4j-2.0.17.jar
   ```
   
   Compared effective POM before/after the change.  Effective POM (with BOMs 
imported, properties substituted etc.) can be generated as:
   
   ```bash
   mvn -N help:effective-pom -Doutput=effective.xml
   ```
   
   https://github.com/adoroszlai/ozone/actions/runs/26864255402


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to