chihsuan opened a new pull request, #10425: URL: https://github.com/apache/ozone/pull/10425
## What changes were proposed in this pull request? `TestOmSnapshotObjectStore` and `TestOmSnapshotObjectStoreWithLinkedBuckets` both call `super(OBJECT_STORE, false, false, false, true)`, i.e. both run with `createLinkedBucket=true`. They are therefore identical, and the non-linked `OBJECT_STORE` snapshot path is no longer exercised by any test. This was introduced in HDDS-11705 (#7434), which added `TestOmSnapshotObjectStoreWithLinkedBuckets` and converted `TestOmSnapshotObjectStore`'s constructor from 4 to 5 arguments, passing `true` for the new `createLinkedBucket` flag instead of `false`. This PR changes `TestOmSnapshotObjectStore` to pass `createLinkedBucket=false`, restoring coverage of the non-linked path. This matches the non-linked/linked pairing that every other layout already has (`TestOmSnapshotFsoWithNativeLib` vs `...WithLinkedBuckets`, `TestOmSnapshotWithoutBucketLinkingLegacy` vs `TestOmSnapshotWithBucketLinkingLegacy`). Noted as a side observation in HDDS-10308, but it is a coverage correctness issue, not a speedup, so tracked separately. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-15473 ## How was this patch tested? Existing `TestOmSnapshotObjectStore` integration test, now exercising the non-linked `OBJECT_STORE` path. Verified via the CI workflow run on the fork. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
