amaliujia commented on code in PR #10410:
URL: https://github.com/apache/ozone/pull/10410#discussion_r3354023991
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineProvider.java:
##########
@@ -61,11 +64,12 @@ public PipelineStateManager getPipelineStateManager() {
return stateManager;
}
- protected abstract Pipeline create(REPLICATION_CONFIG replicationConfig)
- throws IOException;
+ protected abstract Pipeline create(REPLICATION_CONFIG replicationConfig,
+ StorageTier storageTier) throws IOException;
Review Comment:
Should `StorageTier` be part of `REPLICATION_CONFIG` so we do not need to
change abstract interface here?
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/PipelineProvider.java:
##########
@@ -61,11 +64,12 @@ public PipelineStateManager getPipelineStateManager() {
return stateManager;
}
- protected abstract Pipeline create(REPLICATION_CONFIG replicationConfig)
- throws IOException;
+ protected abstract Pipeline create(REPLICATION_CONFIG replicationConfig,
+ StorageTier storageTier) throws IOException;
Review Comment:
Could `StorageTier` be part of `REPLICATION_CONFIG` so we do not need to
change abstract interface here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
