JacksonYao287 commented on a change in pull request #2278:
URL: https://github.com/apache/ozone/pull/2278#discussion_r656721960
##########
File path:
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/protocolPB/StorageContainerLocationProtocolClientSideTranslatorPB.java
##########
@@ -712,6 +718,73 @@ public boolean getReplicationManagerStatus() throws
IOException {
}
+ @Override
+ public boolean startContainerBalancer(Optional<Double> threshold,
+ Optional<Integer> idleiterations,
+ Optional<Integer> maxDatanodesToBalance,
+ Optional<Long> maxSizeToMoveInGB) throws IOException{
+ StartContainerBalancerRequestProto.Builder builder =
+ StartContainerBalancerRequestProto.newBuilder();
+ builder.setTraceID(TracingUtil.exportCurrentSpan());
+
+ //make balancer configuration optional
+ if (threshold.isPresent()) {
+ double tsd = threshold.get();
+ Preconditions.checkState(tsd >= 0.0D && tsd < 1.0D,
+ "threshold should to be specified in range [0.0, 1.0).");
+ builder.setThreshold(tsd);
+ }
+ if (maxSizeToMoveInGB.isPresent()) {
+ long mstm = maxSizeToMoveInGB.get();
+ Preconditions.checkState(mstm > 0,
+ "maxSizeToMoveInGB must be positive.");
+ builder.setMaxSizeToMoveInGB(mstm);
+ }
+ if (maxDatanodesToBalance.isPresent()) {
+ int mdtb = maxDatanodesToBalance.get();
+ Preconditions.checkState(mdtb > 0,
+ "maxDatanodesToBalance must be positive.");
+ builder.setMaxDatanodesToBalance(mdtb);
+ }
+ if (idleiterations.isPresent()) {
+ int idi = idleiterations.get();
+ Preconditions.checkState(idi > 0 || idi == -1,
+ "maxDatanodesToBalance must be positive or" +
+ " -1(infinitly run container balancer).");
+ builder.setIdleiterations(idi);
+ }
+
+ StartContainerBalancerRequestProto request = builder.build();
+ StartContainerBalancerResponseProto response =
+ submitRequest(Type.StartContainerBalancer,
+ builder1 -> builder1.setStartContainerBalancerRequest(request))
+ .getStartContainerBalancerResponse();
+ return response.getStart();
+ }
+
+ @Override
+ public void stopContainerBalancer() throws IOException {
+
+ StopContainerBalancerRequestProto request =
+ StopContainerBalancerRequestProto.getDefaultInstance();
+ submitRequest(Type.StopContainerBalancer,
+ builder -> builder.setStopContainerBalancerRequest(request));
+
+ }
+
+ @Override
+ public boolean getContainerBalancerStatus() throws IOException {
+
+ ContainerBalancerStatusRequestProto request =
Review comment:
seems i have already used 4 black space indent here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
