priyeshkaratha commented on code in PR #10408:
URL: https://github.com/apache/ozone/pull/10408#discussion_r3356844815
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/RootEndpoint.java:
##########
@@ -48,6 +58,101 @@ public class RootEndpoint extends EndpointBase {
@GET
public Response get()
throws OS3Exception, IOException {
+ if (isListDirectoryBucketsRequest()) {
Review Comment:
In practice, all AWS SDK and CLI clients that call ListDirectoryBuckets use
S3 Express signing
(service = "s3express" in the credential scope), because
ListDirectoryBuckets is defined as an
S3 Express Regional endpoint API (Host:
s3express-control.<region>.amazonaws.com). A client
using regular SigV4 (service = "s3") with no query params would be calling
ListBuckets, not
ListDirectoryBuckets — so the fallback to listAllBuckets() is correct in
that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
