amaliujia commented on code in PR #10409:
URL: https://github.com/apache/ozone/pull/10409#discussion_r3361058861
##########
hadoop-ozone/dist/pom.xml:
##########
@@ -37,6 +37,8 @@
<docker.ozone.image.flavor>-rocky</docker.ozone.image.flavor>
<downloadSources>true</downloadSources>
<file.encoding>UTF-8</file.encoding>
+ <!-- ozone-iceberg is built only with JDK 11+, dist matches that via
jdk11-with-iceberg profile -->
+ <include.iceberg>false</include.iceberg>
Review Comment:
Oh sorry, I guess I was thinking about this:
```
<profiles>
<profile>
<id>jdk8-without-iceberg</id>
<activation>
<jdk>1.8</jdk> <!-- or [1.8,1.8] -->
</activation>
<properties>
<include.iceberg>false</include.iceberg>
</properties>
</profile>
```
But the way you are doing in this PR is safe too.
Please feel free to resolve this comment. My comment is minor which mainly
focus on readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
