sreejasahithi commented on PR #10414:
URL: https://github.com/apache/ozone/pull/10414#issuecomment-4646307699
> @sreejasahithi Consider adding `TestAnalyzeSubcommand` that reuses the
volume setup from `TestContainerDirectoryScanner` and runs `ozone debug
datanode container analyze` via `OzoneDebug().getCmd().execute("-D",
hdds.datanode.dir=..., ...)`. That would lock in duplicate reporting output
(including mixed VALID/MISSING_METADATA) and `--count` behavior, which the
scanner tests alone don’t exercise.
@Gargi-jais11 , agreed that we need to add a test for subcommand as
TestContainerDirectoryScanner only covers the scanner layer, not CLI
output/--count. I was planning on adding TestAnalyzeSubcommand in the followup
PRs with orphan and deleted-but-present cases also in place as this PR majorly
is for the scanner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
