devmadhuu commented on PR #10326:
URL: https://github.com/apache/ozone/pull/10326#issuecomment-4646831429

   > Some questions for you devesh!
   > 
   > Potentially too many SCM calls on normal `CLOSED` / `QUASI_CLOSED` reports
   > 
   > Current logic does this:
   > 
   > ```
   > if (isClosedReplicaState(state)) {
   > reconcileContainerFromScm(containerID,containerInfo,reconState,state);
   > return;
   > }
   > ```
   > 
   > That means **any** DN report with replica state `CLOSED` or `QUASI_CLOSED` 
triggers an SCM lookup, regardless of Recon’s current state.
   > 
   > This may be expensive during FCR processing, because most containers in a 
healthy cluster are already `CLOSED`. If every repeated closed replica report 
causes `scmClient.getContainerWithPipeline(...)`, Recon may put unnecessary 
load on SCM.
   
   Yes, so to handle that, few optimizations and how Recon should handle 
various state transitions for containers, refer attached screenshot, need to 
conclude.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to