sreejasahithi commented on code in PR #10309:
URL: https://github.com/apache/ozone/pull/10309#discussion_r3373714370
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
@@ -341,6 +342,11 @@ public MultiDeleteResponse multiDelete(
) throws OS3Exception, IOException {
S3GAction s3GAction = S3GAction.MULTI_DELETE;
+ if (request.getObjects() != null
+ && request.getObjects().size() > S3Consts.S3_DELETE_OBJECTS_MAX_KEYS) {
+ throw newError(S3ErrorTable.MALFORMED_XML, bucketName);
Review Comment:
@peterxcli could you please let me know which would be better to have
`INVALID_ARGUMENT` or `MALFORMED_XML` because looks like aws uses
`MALFORMED_XML` not sure if it later changed it.
we could probably update the message like follows:
> throw newError(S3ErrorTable.MALFORMED_XML, bucketName)
> .withMessage(S3ErrorTable.MALFORMED_XML.getErrorMessage()
> + ". A maximum of " + S3Consts.S3_DELETE_OBJECTS_MAX_KEYS
> + " objects may be specified per request.");
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
