sodonnel commented on a change in pull request #2335:
URL: https://github.com/apache/ozone/pull/2335#discussion_r657874685
##########
File path:
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java
##########
@@ -155,6 +156,9 @@ public BlockOutputStream(
this.token = token;
replicationIndex = pipeline.getReplicaIndex(pipeline.getClosestNode());
+ if (replicationIndex > 0) {
Review comment:
I would tend to agree we should subclass BlockOutputStream here. The
changes are quite small, but they may get larger in the future, and then there
will be a temptation to add more and more EC things into the original class.
The HDFS code is full of "if EC else ..." logic and it makes it harder to
follow the code generally. Its also good to avoid changing the original code if
we can, as it works, and it makes reviews easier. Not just now, but later when
we come to merge the branches. People get nervous when critical code paths get
modified.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
