amaliujia commented on code in PR #10462:
URL: https://github.com/apache/ozone/pull/10462#discussion_r3379271088
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/safemode/AbstractContainerSafeModeRuleTest.java:
##########
@@ -98,7 +100,7 @@ public void testRefreshInitializeContainers() {
containers.add(mockContainer(LifeCycleState.OPEN, 3L));
containers.add(mockContainer(LifeCycleState.CLOSED, 4L));
containers.removeIf(c -> c.containerID().equals(ContainerID.valueOf(8L)));
- containers.add(mockContainer(LifeCycleState.DELETED, 8L));
Review Comment:
We still need to keep `containers.add(mockContainer(LifeCycleState.DELETED,
8L));`?
Because we expect that `deletedContainers` is used to have a container id
from which we call `containers.remove(id)`.
Without this line 101, the test still passes as container does not contain
this deleted container already, but it is not what we to verify.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
