amaliujia commented on code in PR #10471:
URL: https://github.com/apache/ozone/pull/10471#discussion_r3381046355
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/safemode/AbstractContainerSafeModeRuleTest.java:
##########
@@ -96,10 +96,6 @@ public void testRefreshInitializeContainers() {
AbstractContainerSafeModeRule rule = createRule(eventQueue, conf,
containerManager, safeModeManager);
rule.setValidateBasedOnReportProcessing(false);
assertEquals(2, rule.getTotalNumberOfContainers(), "Total number of
containers should be 2");
- containers.add(mockContainer(LifeCycleState.CLOSED, 2L));
- containers.add(mockContainer(LifeCycleState.OPEN, 3L));
- containers.add(mockContainer(LifeCycleState.CLOSED, 4L));
- containers.removeIf(c -> c.containerID().equals(ContainerID.valueOf(8L)));
Review Comment:
@sumitagrawl
This is the place that I felt off. The root cause is in
https://github.com/apache/ozone/pull/10462, we no longer access
`containerManager.getContainers(getContainerType())`, so the mocks here
to`containers` are not accessed at all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
