sodonnel commented on code in PR #10415:
URL: https://github.com/apache/ozone/pull/10415#discussion_r3381669690


##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/StreamBlockInputStream.java:
##########
@@ -186,7 +186,7 @@ private synchronized boolean dataAvailableToRead(int 
length, boolean preRead) th
   }
 
   private synchronized void advancePosition(long delta, boolean preRead) {
-    LOG.debug("{}: advance {} -> {}", getName(streamingReader), position, 
position + delta);
+    LOG.trace("{}: advance {} -> {}", getName(streamingReader), position, 
position + delta);
     position += delta;
     if (preRead && position >= blockLength) {

Review Comment:
   This hasn't changed as part of this PR, but why do we only close the reader 
if preRead is true?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to