jojochuang commented on code in PR #457:
URL: https://github.com/apache/ozone-site/pull/457#discussion_r3384486892
##########
docs/08-developer-guide/04-project/02-release-guide.md:
##########
@@ -617,11 +613,10 @@ If there is a security vulnerability or critical bug
uncovered in a major or min
2. Run all steps from the sections [Update the
Versions](#update-the-ozone-version-on-the-release-branch) through [Publish a
Docker Image for the Release](#publish-a-docker-image-for-the-release), with
the following modifications:
- Do not update the protolock files unless protocol buffers were changed
as part of the fix.
- - When updating the website, all instances of the original major/minor
release should be replaced with this patch version, since we do not want users
downloading the original release anymore.
- - For example, any website text referring to 1.2.0 should be changed to
refer to 1.2.1.
- - Continuing the 1.2.0 to 1.2.1 example, the release/1.2.0 page should
redirect to release/1.2.1.
- - An example pull request to do this is
[here](https://github.com/apache/ozone-site/pull/23).
- - The docs can be added to the website normally as described above in
[Update the Ozone Website](#update-the-ozone-website). The docs link for the
original major/minor release can remain alongside the docs link for the patch
release.
+ - When updating the website, replace the superseded release's row on the
[Downloads page](https://ozone.apache.org/download/) with this patch version,
since we do not want users downloading the original release anymore.
+ - For example, if 1.2.1 is released, the 1.2.0 row on the Downloads page
should be replaced with 1.2.1.
Review Comment:
```suggestion
- For example, if 1.2.1 is released, replace the 1.2.0 row on the
Downloads page with 1.2.1.
```
##########
docs/08-developer-guide/04-project/02-release-guide.md:
##########
@@ -617,11 +613,10 @@ If there is a security vulnerability or critical bug
uncovered in a major or min
2. Run all steps from the sections [Update the
Versions](#update-the-ozone-version-on-the-release-branch) through [Publish a
Docker Image for the Release](#publish-a-docker-image-for-the-release), with
the following modifications:
- Do not update the protolock files unless protocol buffers were changed
as part of the fix.
- - When updating the website, all instances of the original major/minor
release should be replaced with this patch version, since we do not want users
downloading the original release anymore.
- - For example, any website text referring to 1.2.0 should be changed to
refer to 1.2.1.
- - Continuing the 1.2.0 to 1.2.1 example, the release/1.2.0 page should
redirect to release/1.2.1.
- - An example pull request to do this is
[here](https://github.com/apache/ozone-site/pull/23).
- - The docs can be added to the website normally as described above in
[Update the Ozone Website](#update-the-ozone-website). The docs link for the
original major/minor release can remain alongside the docs link for the patch
release.
+ - When updating the website, replace the superseded release's row on the
[Downloads page](https://ozone.apache.org/download/) with this patch version,
since we do not want users downloading the original release anymore.
Review Comment:
```suggestion
- When updating the website, replace the superseded release's row on the
[Downloads page](https://ozone.apache.org/download/) with this patch version,
since users should no longer download the original release.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
