amaliujia commented on PR #10438: URL: https://github.com/apache/ozone/pull/10438#issuecomment-4666847247
I will also review the code today when getting a chance. @yandrey321 really appreciate your work! I am thinking given that this is a hot and critical path, does it make sense that we introduce a config to have a kill-switch and could fall back to `ByteBuffer.wrap`, in case there is any bugs we couldn't discover now? After all the previous `ByteBuffer.wrap` was easy to reason, but now we introduce a lot of new code in the path. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
