sarvekshayr commented on code in PR #10419:
URL: https://github.com/apache/ozone/pull/10419#discussion_r3385901053
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/CompactDBUtil.java:
##########
@@ -38,13 +40,13 @@ public final class CompactDBUtil {
private CompactDBUtil() {
}
- public static void compactTable(OMMetadataManager omMetadataManager,
- String tableName) throws IOException {
+ public static void compactTable(OMMetadataManager omMetadataManager, String
tableName,
Review Comment:
In
[PR#10428](https://github.com/apache/ozone/pull/10428/changes#diff-3142f862b803f3df9de5e0aa4e0d51b7e0d603e9ba84fa853ef2562f82a3c6da),
the `compactTable()` and `compactTableAsync()` methods was overloaded with a
new `int bottommostLevelCompaction` parameter. However, in this patch,
`ManagedCompactRangeOptions.BottommostLevelCompaction compactionType` is being
added directly to the existing method signature.
Should we align this implementation with PR#10428 to maintain consistency?
Also, please note that once either of these PRs is merged, the other will
require conflict resolution as it has similar changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
