ChenSammi commented on code in PR #10318:
URL: https://github.com/apache/ozone/pull/10318#discussion_r3386460084
##########
hadoop-ozone/ozone-manager-plugins/src/main/java/org/apache/hadoop/ozone/om/eventlistener/s3/S3EventNotification.java:
##########
@@ -84,7 +84,9 @@ public enum OzoneEventDataKey {
IS_DIRECTORY("isDirectory"),
IS_RECURSIVE("isRecursive"),
IS_OVERWRITE("isOverwrite"),
- RENAME_FROM_KEY("renameFromKey");
+ RENAME_FROM_KEY("renameFromKey"),
+ TRX_LOG_INDEX("trxLogIndex"),
Review Comment:
@gardenia , thanks for updating the patch. There is objectSequencer in
S3EventNotification.S3ObjectEntity create, is objectSequencer a good place to
have the trxLogIndex? Currently, it looks like objectSequencer is empty.
Our goal is to guarantee that "at-least-once delivery", which means a event
can be delivered multiple times, since trxLogIndex is globally unique in OM,
the receiver can use received trxLogIndex to tell whether event is duplicate or
not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
