yandrey321 commented on code in PR #10478:
URL: https://github.com/apache/ozone/pull/10478#discussion_r3390341425
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -1948,6 +1950,9 @@ private OmKeyInfo getKeyInfo(OmKeyArgs keyArgs) throws
IOException {
@Override
public void close() throws IOException {
+ if (!closed.compareAndSet(false, true)) {
+ return;
+ }
Review Comment:
Close should not require retry and should not throw exceptions. Since there
are multiple steps each step should take care about error handling and let the
other steps to release resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
