amaliujia commented on code in PR #10485:
URL: https://github.com/apache/ozone/pull/10485#discussion_r3400891098
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisServer.java:
##########
@@ -145,6 +145,37 @@ public void testStartOMRatisServer() throws Exception {
"Ratis Server should be in running state");
}
+ /**
+ * RaftPeer.address must always be a hostname:port string, never an
+ * IP:port string. This is what allows gRPC's DnsNameResolver to
+ * re-resolve the peer when its underlying IP changes (Kubernetes pod
+ * restart). If a resolved IP were baked in, recovery would require
+ * a full OM restart.
+ */
+ @Test
+ public void testCreateRaftPeerUsesHostnameAddress() {
+ String hostname = "om-2.om.example.svc.cluster.local";
+ int ratisPort = 9872;
Review Comment:
nit:
int rpcPort = 9862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
