kerneltime commented on PR #10487: URL: https://github.com/apache/ozone/pull/10487#issuecomment-4688044619
Rebased onto the updated PR-2 (#10486) tip and retitled the PR to HDDS-15532 per @szetszwo's subtask request. Most of Copilot's findings on this PR were inherited from PR-1 and PR-2 hunks that ride along on PR-3's diff-against-master; those are now addressed in their owning PRs and will fall out of this PR's diff once they merge. The one finding that needed action here was the "torn value" wording in `HadoopRpcOMFollowerReadFailoverProxyProvider.getConnectionId()`. Copilot correctly noted that reference reads are atomic per JLS, so the term "torn" is wrong — the actual concurrency hazard is stale visibility without a happens-before edge between writer's swap and an unsynchronized reader. Reworded accordingly. Since the file is owned by PR-2, the fix lives there and is included in this PR via rebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
