kerneltime commented on PR #10496: URL: https://github.com/apache/ozone/pull/10496#issuecomment-4688689792
Thanks for the review. Addressed in d90fae9: - **Test-only setter**: made `setBlockInputStreamFactory` package-private and added an eager `Objects.requireNonNull` so a null factory fails fast instead of surfacing as a delayed NPE during reconciliation. - **Assertions**: both now assert the BCSID stays at the exact local value (`LOCAL_BCSID`) rather than just "not the peer value", so a drift to any other wrong value (e.g. 0) is caught too. - **PMD (SingularField)**: the test's `OzoneConfiguration` is now a local variable instead of a field; this was the only PMD violation in the prior run. Ran `checkstyle:check`, `pmd:check`, and the unit test locally on hadoop-hdds/container-service: 0 checkstyle violations, 0 PMD failures, test green. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
