hani-fouladgar commented on code in PR #10494:
URL: https://github.com/apache/ozone/pull/10494#discussion_r3404904530
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/ozone/admin/om/DecommissionOMSubcommand.java:
##########
@@ -67,15 +67,11 @@ public class DecommissionOMSubcommand implements
Callable<Void> {
@CommandLine.Mixin
private OmAddressOptions.MandatoryServiceIdMixin omServiceOption;
- @CommandLine.Option(names = {"-nodeid", "--nodeid"},
- description = "NodeID of the OM to be decommissioned.",
- required = true)
- private String decommNodeId;
+ @CommandLine.ArgGroup(multiplicity = "1")
+ private NodeIdOptions nodeIdOptions;
Review Comment:
In DecommissionOMSubcommand and DecommissionScmSubcommand, the
@ArgGroup(multiplicity = "1") is not there just because of deprecation. It
marks the parameter as required. Inside that group, --nodeid and -nodeid are
just alternate names for the same value, resolved in a getter — the same
pattern as OmAddressOptions
ScmOption, GenericCli, PrepareSubCommand, FilterPipelineOptions, etc. use
plain options because those parameters are optional
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
