sreejasahithi commented on code in PR #10490:
URL: https://github.com/apache/ozone/pull/10490#discussion_r3411005010
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerTask.java:
##########
@@ -1193,6 +1197,10 @@ public List<DatanodeUsageInfo> getUnderUtilizedNodes() {
return underUtilizedNodes;
}
+ public ContainerBalancerSelectionCriteria getSelectionCriteria() {
+ return selectionCriteria;
+ }
+
Review Comment:
since it is only used by tests we can add `@VisibleForTesting` here.
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/balancer/ContainerBalancerSelectionCriteria.java:
##########
@@ -365,6 +365,10 @@ public void addToExcludeDueToFailContainers(ContainerID
container) {
this.excludeContainersDueToFailure.add(container);
}
+ public Set<ContainerID> getExcludeDueToFailContainers() {
+ return excludeContainersDueToFailure;
+ }
+
Review Comment:
since it is only used by tests we can add `@VisibleForTesting` here.
we can also make it package-private access.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
