Gargi-jais11 commented on code in PR #10498:
URL: https://github.com/apache/ozone/pull/10498#discussion_r3418434162
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java:
##########
@@ -2752,6 +2754,30 @@ public void deleteObjectTagging(OmKeyArgs args) throws
IOException {
handleError(omResponse);
}
+ // TODO: Add putBucketTagging and deleteBucketTagging APIs.
+
+ @Override
+ public Map<String, String> getBucketTagging(OmBucketArgs args) throws
IOException {
+ BucketArgs bucketArgs = BucketArgs.newBuilder()
+ .setVolumeName(args.getVolumeName())
+ .setBucketName(args.getBucketName())
+ .build();
+
+ GetBucketTaggingRequest req =
+ GetBucketTaggingRequest.newBuilder()
+ .setBucketArgs(bucketArgs)
+ .build();
+
+ OMRequest omRequest = createOMRequest(Type.GetBucketTagging)
+ .setGetBucketTaggingRequest(req)
+ .build();
+
+ GetBucketTaggingResponse resp =
+ handleError(submitRequest(omRequest)).getGetBucketTaggingResponse();
+
+ return KeyValueUtil.getFromProtobuf(resp.getTagsList());
+ }
Review Comment:
Correct, I have removed this implementation will support in follow up PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
