fmorg-git commented on code in PR #10521:
URL: https://github.com/apache/ozone/pull/10521#discussion_r3422898149
##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/metrics/S3GatewayMetrics.java:
##########
@@ -303,14 +303,20 @@ public void close() {
*
* @return S3GatewayMetrics
*/
- public static synchronized S3GatewayMetrics create(OzoneConfiguration conf) {
- if (instance != null) {
- return instance;
+ public static S3GatewayMetrics create(OzoneConfiguration conf) {
+ S3GatewayMetrics local = instance;
Review Comment:
using the local variable is a micro-optimization on the fast path (i.e. when
instance is not null) so that there is one volatile read instead of two
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
