jojochuang commented on code in PR #10477:
URL: https://github.com/apache/ozone/pull/10477#discussion_r3432503282
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java:
##########
@@ -275,7 +383,10 @@ public static <R, E extends Exception> R
executeInNewSpan(String spanName,
* @return the value returned by {@code supplier}
*/
private static <R, E extends Exception> R executeInSpan(Span span,
- CheckedSupplier<R, E> supplier) throws E {
+ CheckedSupplier<R,
E> supplier) throws E {
Review Comment:
here too; there are a few more in this class.
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/tracing/TracingUtil.java:
##########
@@ -255,7 +363,7 @@ static Map<String, LoopSampler>
parseSpanSamplingConfig(String configStr) {
* If a parent span exists in the current context, this becomes a child span.
*/
public static <E extends Exception> void executeInNewSpan(String spanName,
- CheckedRunnable<E> runnable) throws E {
+ CheckedRunnable<E>
runnable) throws E {
Review Comment:
code style: this line change is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
