adoroszlai commented on PR #10532: URL: https://github.com/apache/ozone/pull/10532#issuecomment-4740462562
> > `ContainerHealthSchemaManager.batchDeleteSCMStatesForContainers` is only called from tests, can we delete it? > > Yes, we can remove it as long as our test uses some other real code logic hitting the actual product code and able to test the batch delete performance. Thanks @devmadhuu for checking. Yes, product code uses another method: https://github.com/apache/ozone/blob/fa1b3a35f18c14d40c32dca7bb2595c69276dd3a/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ReconReplicationManager.java#L498-L504 which is also covered by the performance test: https://github.com/apache/ozone/blob/fa1b3a35f18c14d40c32dca7bb2595c69276dd3a/hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/persistence/TestUnhealthyContainersDerbyPerformance.java#L635 So I suggest splitting the task: 1. "Further speed up TestUnhealthyContainersDerbyPerformance": remove test case for `batchDeleteSCMStatesForContainers` 2. "Improve deleteScmStatesForContainers performance": this PR, needs further work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
