sodonnel commented on a change in pull request #2353: URL: https://github.com/apache/ozone/pull/2353#discussion_r658630755
########## File path: hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/pipeline/TestWritableECContainerProvider.java ########## @@ -0,0 +1,376 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.hadoop.hdds.scm.pipeline; + +import org.apache.hadoop.hdds.client.ECReplicationConfig; +import org.apache.hadoop.hdds.client.ReplicationConfig; +import org.apache.hadoop.hdds.conf.ConfigurationSource; +import org.apache.hadoop.hdds.conf.OzoneConfiguration; +import org.apache.hadoop.hdds.protocol.proto.HddsProtos; +import org.apache.hadoop.hdds.scm.PipelineChoosePolicy; +import org.apache.hadoop.hdds.scm.ScmConfigKeys; +import org.apache.hadoop.hdds.scm.container.ContainerID; +import org.apache.hadoop.hdds.scm.container.ContainerInfo; +import org.apache.hadoop.hdds.scm.container.ContainerManagerV2; +import org.apache.hadoop.hdds.scm.container.ContainerNotFoundException; +import org.apache.hadoop.hdds.scm.container.common.helpers.ExcludeList; +import org.apache.hadoop.hdds.scm.pipeline.choose.algorithms.HealthyPipelineChoosePolicy; +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import org.mockito.Matchers; +import org.mockito.Mockito; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.NavigableSet; +import java.util.Set; + +import static org.apache.hadoop.hdds.conf.StorageUnit.BYTES; +import static org.apache.hadoop.hdds.scm.pipeline.Pipeline.PipelineState.CLOSED; +import static org.apache.hadoop.hdds.scm.pipeline.Pipeline.PipelineState.OPEN; +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertFalse; +import static org.junit.Assert.assertNotEquals; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; + +/** + * Tests to validate the WritableECContainerProvider works correctly. + */ +public class TestWritableECContainerProvider { + + private static final Logger LOG = LoggerFactory + .getLogger(TestWritableECContainerProvider.class); + private static final String OWNER = "SCM"; + private PipelineManager pipelineManager = MockPipelineManager.getInstance(); + private ContainerManagerV2 containerManager + = Mockito.mock(ContainerManagerV2.class); + private PipelineChoosePolicy pipelineChoosingPolicy + = new HealthyPipelineChoosePolicy(); + + private ConfigurationSource conf; + private WritableContainerProvider provider; + private ReplicationConfig repConfig; + private int minPipelines; + + private Map<ContainerID, ContainerInfo> containers; + + @Before + public void setup() throws ContainerNotFoundException { + repConfig = new ECReplicationConfig(3, 2); + conf = new OzoneConfiguration(); + WritableECContainerProvider.WritableECContainerProviderConfig providerConf = + conf.getObject(WritableECContainerProvider + .WritableECContainerProviderConfig.class); + minPipelines = providerConf.getMinimumPipelines(); + containers = new HashMap<>(); + provider = new WritableECContainerProvider( + conf, pipelineManager, containerManager, pipelineChoosingPolicy); + + Mockito.doAnswer(call -> { + Pipeline pipeline = (Pipeline)call.getArguments()[2]; + ContainerInfo container = createContainer(pipeline, + repConfig, System.nanoTime()); + pipelineManager.addContainerToPipeline( + pipeline.getId(), container.containerID()); + containers.put(container.containerID(), container); + return container; + }).when(containerManager).getMatchingContainer(Matchers.anyLong(), + Matchers.anyString(), Matchers.any(Pipeline.class)); + + Mockito.doAnswer(call -> + containers.get((ContainerID)call.getArguments()[0])) + .when(containerManager).getContainer(Matchers.any(ContainerID.class)); + + } + + @After Review comment: True, I have removed it. I usually just create setup and teardown out of habit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
