henrybear327 commented on PR #10456: URL: https://github.com/apache/ozone/pull/10456#issuecomment-4763685583
> @henrybear327 thanks for the patch, this reads really cleanly! > > but I got one thought: a lot of the bring-up here (storage init, port allocation, readiness, shutdown) overlaps with what `MiniOzoneClusterImpl` already does. Did you consider building on it or extracting a shared piece, so the two don't drift apart as SCM/OM init changes? Not a blocker — just curious if it was ruled out for a reason. Thanks! Hi @rich7420 , thanks for the question. I think this stream of work is quite different from the `MiniOzoneClusterImpl` implementation. `MiniOzoneClusterImpl` lives in `ozone-mini-cluster`, a test-only module (it depends on `hdds-test-utils`) that isn't packaged into the distribution. `ozone local` ships from `ozone-tools` and is meant to be run directly via the CLI, so the use case is quite different and the implementations will diverge in the long run — configuration, node setup, persistent ports (e.g. ports.properties for devcontainer/compose reuse vs. MiniOzoneCluster's random ephemeral ports), etc. Not sure if this answers your question! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
