priyeshkaratha commented on code in PR #10564:
URL: https://github.com/apache/ozone/pull/10564#discussion_r3450028996
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java:
##########
@@ -203,6 +203,9 @@ public void failVolume() {
if (volumeIOStats != null) {
volumeIOStats.unregister();
}
+ if (volumeInfoMetrics != null) {
+ volumeInfoMetrics.unregister();
Review Comment:
Yes, @adoroszlai this a valid point. While unregistering the metrics it will
impact observability for failed volumes.
I can see in dn get jmx using
`$http.get("jmx?qry=Hadoop:service=HddsDatanode,name=VolumeInfoMetrics*")`
So this value may differ as you mentioned.
So I think better to fix metrics wise NPE handlers instead of changing the
behavior. I will close this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
