spacemonkd commented on code in PR #10426:
URL: https://github.com/apache/ozone/pull/10426#discussion_r3450143988
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/PendingDeletionEndpoint.java:
##########
@@ -87,12 +87,15 @@ private Response handleDataNodeMetrics(Integer limit) {
.entity("Limit query parameter must be at-least 1").build();
}
- DataNodeMetricsServiceResponse response =
dataNodeMetricsService.getCollectedMetrics(limit);
- if (response.getStatus() ==
DataNodeMetricsService.MetricCollectionStatus.FINISHED) {
- return Response.ok(response).build();
- } else {
- return Response.accepted(response).build();
+ Object response = dataNodeMetricsService.getCollectedMetrics(limit);
+ if (response instanceof DataNodeMetricsCompleteResponse) {
+ DataNodeMetricsCompleteResponse completeResponse =
(DataNodeMetricsCompleteResponse) response;
+ if (completeResponse.getStatus() ==
DataNodeMetricsService.MetricCollectionStatus.FINISHED) {
+ return Response.ok(completeResponse).build();
+ }
+ return Response.accepted(completeResponse).build();
Review Comment:
Possible dead code? It seems like getCollectedMetrics() would only return
type `DataNodeMetricsCompleteResponse` when `currentStatus == FINISHED`.
So the inner if is always true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
