ArafatKhan2198 commented on code in PR #10524: URL: https://github.com/apache/ozone/pull/10524#discussion_r3453403614
########## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/chatbot/agent/LlmToolSpecFactory.java: ########## @@ -0,0 +1,244 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.recon.chatbot.agent; + +import com.google.inject.Singleton; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import org.apache.hadoop.ozone.recon.chatbot.llm.LLMClient.ToolSpec; + +/** + * Builds native LLM tool specifications (names, descriptions, parameters). + * Descriptions are semantic (when to use / not use) and complement recon-tool-semantics.md. + */ +@Singleton +public class LlmToolSpecFactory { + + public List<ToolSpec> getToolSpecs() { Review Comment: Agreed this should not be rebuilt on every chat request. Updated in the latest commit: tool specs are built once in the `@Inject` constructor and stored in an unmodifiable toolSpecs field. `getToolSpecs()` now just returns that cached list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
