SaketaChalamchala commented on code in PR #10581:
URL: https://github.com/apache/ozone/pull/10581#discussion_r3456109628
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestSnapshotDiffManager.java:
##########
@@ -1170,105 +1167,110 @@ private void uploadSnapshotDiffJobToDb(SnapshotInfo
fromSnapshot,
private static Stream<Arguments> threadPoolFullScenarios() {
return Stream.of(
- Arguments.of("When there is a wait time between job batches",
- 500L, 45, 0),
- Arguments.of("When there is no wait time between job batches",
- 0L, 20, 25)
+ Arguments.of("When the pool drains between job batches",
+ true, 45, 0),
+ // 10 running + 10 queued = 20 accepted, remaining 25 rejected
+ Arguments.of("When the pool does not drain between job batches",
+ false, 20, 25)
Review Comment:
Thanks for the patch @rhalm.
nit: Use `full_thread_pool_size = 2 *
OZONE_OM_SNAPSHOT_DIFF_THREAD_POOL_SIZE ` and `45 - full_thread_pool_size` for
the expected accepted and rejected jobs here.
Otherwise, LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
