ivandika3 commented on code in PR #10591:
URL: https://github.com/apache/ozone/pull/10591#discussion_r3461010083


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerHAFollowerReadWithAllRunning.java:
##########
@@ -571,4 +574,40 @@ void testClientWithLocalLeaseEnabled() throws Exception {
       IOUtils.closeQuietly(ozoneClient);
     }
   }
+
+  @Test
+  void testGrpcClientFollowerReadTargetsFollower() throws Exception {
+    OzoneConfiguration clientConf = new OzoneConfiguration(getConf());
+    clientConf.setBoolean(OZONE_CLIENT_FOLLOWER_READ_ENABLED_KEY, true);
+    clientConf.set(OZONE_CLIENT_FOLLOWER_READ_DEFAULT_CONSISTENCY_KEY, 
"LOCAL_LEASE");
+    clientConf.set(OZONE_OM_TRANSPORT_CLASS, 
GrpcOmTransportFactory.class.getName());

Review Comment:
   Instead of adding a test case, how about we make the test parameterized over 
the `OZONE_OM_TRANSPORT_CLASS` for gRPC and Hadoop client so we can see that 
both will work the same. Not sure how complicated it is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to