errose28 commented on code in PR #10548:
URL: https://github.com/apache/ozone/pull/10548#discussion_r3464350502
##########
hadoop-ozone/cli-admin/src/main/java/org/apache/hadoop/ozone/admin/upgrade/FinalizeSubCommand.java:
##########
@@ -33,18 +35,23 @@
mixinStandardHelpOptions = true,
versionProvider = HddsVersionProvider.class
)
-public class FinalizeSubCommand extends AbstractSubcommand implements
Callable<Void> {
+public class FinalizeSubCommand extends AbstractSubcommand implements
Callable<Integer> {
@CommandLine.Mixin
private OmAddressOptions.OptionalServiceIdOrHostMixin omAddressOptions;
@Override
- public Void call() throws Exception {
+ public Integer call() throws Exception {
try (OzoneManagerProtocol client = getClient()) {
+ OzoneManagerVersion omVersion =
RpcClient.getOmVersion(client.getServiceInfo());
+ if (!OzoneManagerVersion.ZDU.isSupportedBy(omVersion)) {
+ err().println("OM does not support ZDU. The cluster should be
finalized with `ozone admin om finalizeupgrade`");
Review Comment:
nit. Remove the acronym for a more user friendly message. Can be changed in
one of the follow-up CLI PRs instead of this one.
```suggestion
err().println("OM does not support zero downtime upgrade. The
cluster should be finalized with `ozone admin om finalizeupgrade`");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
