ivandika3 commented on PR #10183: URL: https://github.com/apache/ozone/pull/10183#issuecomment-4786331866
> And I think we should apply this concept to conditional put, too. > > - CreateKey.preExecute -> admission preparation > - CreateKey.validateAndUpdateCache -> serialized admission > - CommitKey.preExecute -> commit-request admission preparation / best-effort precondition check > - CommitKey.validateAndUpdateCache -> serialized commit revalidation @peterxcli Thanks for the concept, I agree. We can do check on the preExecute to reduce the number of transactions, but we should also do a check on validateAndUpdateCache for correctness. Let me review this soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
